Test bridge pool wasm #737

batconjurer · 2022-11-04T15:00:38Z

This PR depends on #729 and

fixes the wasm for submitting a transfer to the ethereum bridge pool.
Adds some functionality to a set of testing tools that allow us to test that vps accept changes generated by wasm.
Fixes some inconsistencies between erc20 multitoken keys and other multitoken keys (the entirety of which might be addressed later).
Adds tests that the wasm changes are accepted by the bridge pool vp.

…/ethbridge/eth-bridge-vp-escrow-nam

…owing nam

…-bridge-vp-escrow-nam

…/ethbridge/eth-bridge-vp-escrow-nam

…ridge/eth-bridge-vp-escrow-nam

…ng and a couple of small todos

…/ethbridge/bridge-pool-cli

…pool tx wasm and added test

…bridge-pool-cli

Co-authored-by: Tiago Carvalho <[email protected]>

…bridge-pool-wasms

…dar cli binary

…bridge-pool-wasms

james-chf

some xans need to become nams

shared/src/types/ethereum_events.rs

tests/src/native_vp/eth_bridge_pool.rs

wasm/wasm_source/src/tx_bridge_pool.rs

tests/src/vm_host_env/tx.rs

james-chf · 2022-11-09T12:13:07Z

shared/src/ledger/eth_bridge/storage/wrapped_erc20s.rs

            .push(&BALANCE_KEY_SEGMENT.to_owned())
            .expect("should always be able to construct this key")
-            .push(&format!("#{}", owner.encode()))
+            .push(&owner.to_db_key())


yeah this way is much better, the previous format way was a hack

sug0 · 2022-11-09T09:00:53Z

tests/src/native_vp/eth_bridge_pool.rs

+            &albert_address(),
+            &xan(),
+            None,
+            BERTHA_WEALTH.into(),


is albert stealing from bertha?

That bastard!

wasm/wasm_source/src/tx_bridge_pool.rs

Co-authored-by: James <[email protected]>

james-chf

lgtm, there are a few things to PR back to main:

TestTxEnv::execute_tx fn
the namadac tx flag changes
TestTxEnv::credit_tokens signature change and usages in wasm/wasm_source

shared/src/ledger/eth_bridge/storage/wrapped_erc20s.rs

tests/src/e2e/ledger_tests.rs

tests/src/vm_host_env/tx.rs

batconjurer · 2022-11-14T09:38:41Z

lgtm, there are a few things to PR back to main:

* `TestTxEnv::execute_tx` fn

* the `namadac tx` flag changes

* `TestTxEnv::credit_tokens` signature change and usages in `wasm/wasm_source`

Covered by PRs #738 and #775

batconjurer · 2022-11-14T09:39:03Z

pls update wasm

batconjurer added 13 commits October 31, 2022 13:54

[feat]: Ethereum bridge vp allows escrowing nam

bc09908

Merge branch 'bat/ethbridge/bp-vp-wnam-address-from-storage' into bat…

07a6af3

…/ethbridge/eth-bridge-vp-escrow-nam

[feat]: Initialized VP substorage

adaeb0b

[chore]: Added unit tests checking that the eth bridge vp allows escr…

73abdc9

…owing nam

[feat]: Added bridge pool defs to the cli

e03e3fc

Merge branch 'bat/ethbridge/bp-vp-escrow-wnam' into bat/ethbridge/eth…

123369d

…-bridge-vp-escrow-nam

Merge branch 'bat/ethbridge/bp-vp-wnam-address-from-storage' into bat…

c17254f

…/ethbridge/eth-bridge-vp-escrow-nam

Merge branch 'bat/ethbridge/query-bridge-merkle-proofs' into bat/ethb…

393527b

…ridge/eth-bridge-vp-escrow-nam

[feat]: Added a cli for interacting with the bridge pool. Needs testi…

6831014

…ng and a couple of small todos

[chore]: Merging in eth-bridge-integration

31e328c

Merge branch 'bat/ethbridge/bp-vp-wnam-address-from-storage' into bat…

3f0bc2d

…/ethbridge/bridge-pool-cli

[feat]: Added tooling for testing wasms and vps. Adjusted the bridge …

3cd4d7a

…pool tx wasm and added test

Merge branch 'bat/ethbridge/bridge-pool-cli' into bat/ethbridge/test-…

3a31cfe

…bridge-pool-cli

batconjurer requested review from james-chf and sug0 November 4, 2022 15:00

batconjurer and others added 6 commits November 7, 2022 10:33

Update apps/src/lib/client/eth_bridge_pool.rs

3a67de1

Co-authored-by: Tiago Carvalho <[email protected]>

[feat]: Migrated the add transfer to eth bridge pool command to namadac

fd99767

Merge branch 'eth-bridge-integration' into bat/ethbridge/bridge-pool-cli

b6112b4

Merge branch 'bat/ethbridge/bridge-pool-cli' into bat/ethbridge/test-…

36bd16b

…bridge-pool-wasms

[fix]: Enriched an error msg, removed stray wallet cmds from the nama…

2674b64

…dar cli binary

Merge branch 'bat/ethbridge/bridge-pool-cli' into bat/ethbridge/test-…

fcf583a

…bridge-pool-wasms

james-chf suggested changes Nov 9, 2022

View reviewed changes

sug0 reviewed Nov 9, 2022

View reviewed changes

batconjurer and others added 3 commits November 10, 2022 12:26

Update wasm/wasm_source/src/tx_bridge_pool.rs

32c6e5a

Co-authored-by: James <[email protected]>

Update tests/src/native_vp/eth_bridge_pool.rs

8073987

Co-authored-by: James <[email protected]>

[fix]: Changed some xan to nam, fixed some arg strings in e2e tests

5addcd8

sug0 self-requested a review November 11, 2022 11:20

sug0 approved these changes Nov 11, 2022

View reviewed changes

batconjurer requested a review from james-chf November 11, 2022 11:21

james-chf suggested changes Nov 11, 2022

View reviewed changes

shared/src/ledger/eth_bridge/storage/wrapped_erc20s.rs Show resolved Hide resolved

tests/src/e2e/ledger_tests.rs Show resolved Hide resolved

tests/src/vm_host_env/tx.rs Show resolved Hide resolved

james-chf mentioned this pull request Nov 11, 2022

Add more logging around vote extensions #764

Merged

batconjurer requested a review from james-chf November 14, 2022 09:39

james-chf approved these changes Nov 14, 2022

View reviewed changes

batconjurer merged commit fdd211a into eth-bridge-integration Nov 14, 2022

batconjurer deleted the bat/ethbridge/test-bridge-pool-wasms branch November 14, 2022 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test bridge pool wasm #737

Test bridge pool wasm #737

Uh oh!

batconjurer commented Nov 4, 2022 •

edited

Loading

Uh oh!

james-chf left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

james-chf Nov 9, 2022

Uh oh!

sug0 Nov 9, 2022

Uh oh!

batconjurer Nov 10, 2022

Uh oh!

Uh oh!

james-chf left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

batconjurer commented Nov 14, 2022

Uh oh!

batconjurer commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Test bridge pool wasm #737

Test bridge pool wasm #737

Uh oh!

Conversation

batconjurer commented Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

james-chf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

james-chf Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

sug0 Nov 9, 2022

Choose a reason for hiding this comment

Uh oh!

batconjurer Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

james-chf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

batconjurer commented Nov 14, 2022

Uh oh!

batconjurer commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

batconjurer commented Nov 4, 2022 •

edited

Loading

james-chf left a comment •

edited

Loading

james-chf left a comment •

edited

Loading