-
Notifications
You must be signed in to change notification settings - Fork 1k
Refactor SDK args and sigs (backport #4816) #4886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,752
−1,346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1e39180)
(cherry picked from commit dd0d9bc)
(cherry picked from commit 5427a95)
(cherry picked from commit c16c923)
…tchers (cherry picked from commit 5020964)
(cherry picked from commit 8024df1)
(cherry picked from commit 5f05408)
(cherry picked from commit 167a642)
(cherry picked from commit 597df8c)
(cherry picked from commit c6b8334)
(cherry picked from commit b629788)
(cherry picked from commit a0f462f)
(cherry picked from commit 20991d2)
(cherry picked from commit c096ccb)
(cherry picked from commit 7106c1f)
(cherry picked from commit f19da12)
…eal_pk txs (cherry picked from commit 2060a0a)
(cherry picked from commit 9e76505)
(cherry picked from commit cde13a2)
(cherry picked from commit 031c177)
…e provided (cherry picked from commit df6cb55)
(cherry picked from commit 8111e2d)
(cherry picked from commit eec8a90)
(cherry picked from commit 0fb380f)
(cherry picked from commit 603b826)
(cherry picked from commit 3394fd7)
Contributor
Author
🧪 CI InsightsHere's what we observed from your CI run for 445bad6. 🟢 All jobs passed!But CI Insights is watching 👀 |
tzemanovic
approved these changes
Oct 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3901 .
Closes #3883.
Reworks the sdk to address the followings:
dumpanddry-runargs by making the enum (inner or wrapper)SigningTxDataand move it to a newSigningWrapperDatawhich contains all the signing data for a batchaux_signing_dataMASPaddress as a tx owner. The owner should not be specified in these casesbuild_batchfunctionreveal_pk(no signature is needed for this transaction)Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repoThis is an automatic backport of pull request #4816 done by [Mergify](https://mergify.com).