Skip to content

merge queue: embarking main (58a926b), #4877 and #4816 together #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 31 commits into from
Closed

merge queue: embarking main (58a926b), #4877 and #4816 together #4881

wants to merge 31 commits into from

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 1, 2025 •
edited
Loading

✨ Pull request #4877 which was ahead in the queue has been dequeued (for the following reason: checks failed). The pull request #4816 has been re-embarked. ✨

Branch main (58a926b), #4877 and #4816 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4816.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
    • check-success = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
    • check-success = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-wasm
    • check-skipped = test-wasm
    • check-success = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
    • check-success = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
    • check-success = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
    • check-success = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
    • check-success = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-unit
    • check-skipped = test-unit
    • check-success = test-unit
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Required conditions to stay in the queue:

  • #approved-reviews-by >= 1
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • base = main
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
---
checking_base_sha: c5778185dff518035ad1acf9b6ba0ad33b183ae2
previous_failed_batches: []
pull_requests:
  - number: 4816
...

grarco and others added 30 commits September 30, 2025 09:56
@grarco
Refactors the signatures structures of the SDK
1e39180
@grarco
Merges the two dry-run args into a single one
dd0d9bc
@grarco
Merges the two dump-tx args into a single one
5427a95
@grarco
Separates wrapper-specific arguments into a specific type
c16c923
@grarco
Misc improvements to sdk interfaces and removal of some useless dispa…
5020964 
…tchers
@grarco
Changes the interface of fee validation
8024df1
@grarco
Removes handling of MASP account as transaction's owner
5f05408
@grarco
Slight improvement to build_batch
167a642
@grarco
Refactors signing of custom transactions
597df8c
@grarco
Fixes the accounting of the number of signatures
c6b8334
@grarco
Adds a wrapper check before tx submission
b629788
@grarco
Fixes broken tests
a0f462f
@grarco
Refactors custom tx builder
20991d2
@grarco
Refactors inner tx signers' extraction
c096ccb
@grarco
Removes redundant default signer
7106c1f
@grarco
Simplifies the interface of signing data functions
f19da12
@grarco
Fixes warning message in client and removes unnecessary owner for rev…
2060a0a 
…eal_pk txs
@grarco
Fixes comment typo
9e76505
@grarco
Refactors extraction of signing data into a separate function
cde13a2
@grarco
Removes unnecessary gas-payer from integration test
031c177
@grarco
Avoids generating empty auth section when no serialized signatures ar…
df6cb55 
…e provided
@grarco
Fixes broken masp test
8111e2d
@grarco
Reverts the logic of inner_tx_signers
eec8a90
@grarco
Upgrades build_batch to support batched transactions
0fb380f
@grarco
Changelog #4816
73c9efd
@grarco
Removes unused handling of failed atomic batch
46f5107
@grarco
Changelog #4450
2836176
@grarco
Fixes typo in changelog
603b826
@tzemanovic
ci: add missing SDK issue category
3394fd7
@mergify
Merge of #4877
c577818
@mergify mergify bot closed this Oct 1, 2025
@mergify mergify bot deleted the mergify/merge-queue/fed55f8af3 branch October 1, 2025 16:04
@mergify
Copy link
Contributor Author

mergify bot commented Oct 1, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 93523bc.

❌ Job Failures

Pipeline Job Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (3) Healthy 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grarco @tzemanovic