Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 15, 2024

Describe your changes

  • Adds property tests for malleability attacks on transactions
  • Improves test_wrapper_unknown_address
  • Removes old references to encrypted/decrypted txs

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3925 done by [Mergify](https://mergify.com).

@grarco grarco self-requested a review November 15, 2024 15:33
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (430a97c) to head (55bca4d).
Report is 11 commits behind head on maint-0.45.

Files with missing lines Patch % Lines
crates/node/src/shell/process_proposal.rs 88.23% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           maint-0.45    #4038      +/-   ##
==============================================
+ Coverage       73.88%   74.04%   +0.16%     
==============================================
  Files             341      341              
  Lines          106494   106561      +67     
==============================================
+ Hits            78684    78907     +223     
+ Misses          27810    27654     -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco removed their request for review November 15, 2024 16:11
@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 15, 2024
@grarco grarco self-requested a review November 15, 2024 16:56
@mergify mergify bot merged commit 8c4f48d into maint-0.45 Nov 15, 2024
23 of 24 checks passed
@mergify mergify bot deleted the mergify/bp/maint-0.45/pr-3925 branch November 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants