-
Notifications
You must be signed in to change notification settings - Fork 1k
Murisi/fix masp change #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/fix masp change #3954
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
- Coverage 74.00% 73.94% -0.07%
==========================================
Files 341 341
Lines 106615 106383 -232
==========================================
- Hits 78901 78660 -241
- Misses 27714 27723 +9 ☔ View full report in Codecov by Sentry. |
| }); | ||
| assert!(captured.result.is_ok()); | ||
| assert!(captured.contains("nam: 0")); | ||
| assert!(captured.contains("nam: 1000")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes to due to the new way we handle the changes without the Changes type?
Describe your changes
An attempt to fix the MASP so that rewards can always be withdrawn without restrictions and to also enable the unshielding of untimestamped assets in all circumstances (including those where an asset is subsequently removed from the reward set). More specifically, the following changes have been made:
AssetTypes with computations over sums ofAddresses to reduce the chances that mismatched epochs cause parts of a balance to be hiddenChecklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo