Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

Describe your changes

On init-chain, the node should be checking that the genesis files have not been tempered with by using the Chain ID.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic marked this pull request as ready for review September 25, 2024 11:31
@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.83%. Comparing base (be38d4c) to head (84ad106).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
crates/apps_lib/src/config/genesis/chain.rs 87.93% 7 Missing ⚠️
crates/node/src/utils.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3843   +/-   ##
=======================================
  Coverage   72.82%   72.83%           
=======================================
  Files         338      338           
  Lines      104220   104286   +66     
=======================================
+ Hits        75897    75955   +58     
- Misses      28323    28331    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 25, 2024
mergify bot added a commit that referenced this pull request Sep 25, 2024
@mergify mergify bot merged commit f88c4b9 into main Sep 25, 2024
@mergify mergify bot deleted the tomas/check-genesis branch September 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants