Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 17, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (e603759) and #3804 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3804.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 3804
...

@mergify mergify bot closed this Sep 17, 2024
@mergify mergify bot deleted the mergify/merge-queue/8954f56588 branch September 17, 2024 17:06
@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 85.93750% with 36 lines in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (e603759) to head (12453e3).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/lib.rs 58.75% 33 Missing ⚠️
crates/node/src/shims/abcipp_shim_types.rs 0.00% 1 Missing ⚠️
crates/trans_token/src/vp.rs 98.78% 1 Missing ⚠️
crates/tx_prelude/src/token.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3822      +/-   ##
==========================================
+ Coverage   72.79%   72.82%   +0.03%     
==========================================
  Files         338      338              
  Lines      103995   104236     +241     
==========================================
+ Hits        75701    75910     +209     
- Misses      28294    28326      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants