Skip to content

Conversation

@brentstone
Copy link
Collaborator

Describe your changes

This work would not be possible without @sug0 @Fraccaman @grarco @batconjurer

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@brentstone brentstone marked this pull request as ready for review September 8, 2024 18:28
@brentstone brentstone requested a review from grarco September 8, 2024 18:34
@codecov
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (59fdda8) to head (373939d).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3788      +/-   ##
==========================================
- Coverage   72.69%   72.69%   -0.01%     
==========================================
  Files         338      338              
  Lines      104324   104324              
==========================================
- Hits        75839    75837       -2     
- Misses      28485    28487       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman self-requested a review September 8, 2024 20:14
Copy link
Collaborator

@Fraccaman Fraccaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a test

@brentstone
Copy link
Collaborator Author

Tests are for losers

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 9, 2024
@brentstone brentstone requested a review from Fraccaman September 9, 2024 08:09
@brentstone brentstone dismissed Fraccaman’s stale review September 9, 2024 09:22

Changes have been made

mergify bot added a commit that referenced this pull request Sep 9, 2024
@mergify mergify bot merged commit ff2f43c into main Sep 9, 2024
@mergify mergify bot deleted the brent/update-params-query branch September 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants