Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Sep 5, 2024

Describe your changes

Closes #3360.

Fixes some bugs in the dry-run implementation and refactors it to reuse dispatch_inner_txs instead of rebuilding the same logic.

Also some misc updates to comments/error messages.

This PR is based on #3746 (diffs: https://github.com/anoma/namada/pull/3758/files/9aee33a0c44bf0ab70da18185727ba664d6b60d9..999a89c11a908a4a4130c05be4c34c3003dd4e23)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

This was referenced Sep 5, 2024
grarco added a commit that referenced this pull request Sep 5, 2024
@grarco grarco marked this pull request as ready for review September 5, 2024 15:58
@grarco grarco requested review from tzemanovic and yito88 September 5, 2024 15:58
grarco added a commit that referenced this pull request Sep 6, 2024
@grarco grarco force-pushed the grarco/improve-dry-run branch from 1c91f7a to 999a89c Compare September 6, 2024 09:16
@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (ef00f27) to head (999a89c).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/vp/mod.rs 0.00% 1 Missing ⚠️
crates/node/src/dry_run_tx.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3758   +/-   ##
=======================================
  Coverage   72.41%   72.42%           
=======================================
  Files         335      335           
  Lines      104005   103968   -37     
=======================================
- Hits        75320    75299   -21     
+ Misses      28685    28669   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 8, 2024
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2024

Hey @grarco, your pull request has been dequeued due to the following reason: CONFLICT_WITH_PULL_AHEAD.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@grarco
Copy link
Collaborator Author

grarco commented Sep 8, 2024

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@grarco grarco closed this Sep 8, 2024
@grarco grarco force-pushed the grarco/improve-dry-run branch from 999a89c to 59fdda8 Compare September 8, 2024 13:20
grarco added a commit that referenced this pull request Sep 8, 2024
@grarco grarco mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor dry_run

3 participants