Enable the signing logic to fall back to the hardware wallet if secret key is not found. #3730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently the transaction signing logic fails fall back to the hardware wallet if the secret key is not found in the wallet store. This is because an error is propagated as soon as the secret key lookup fails. This PR fixes that. Additionally, the signing code now checks that the number of public keys used in signing exceeds the given account's threshold.
Checklist before merging
breaking::labels