derive Serialize for PosParams, OwnedPosParams, GovernanceParameters #3702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would enable our client library `@fadroma/namada` to automatically convert the response from `/vp/pos/pos_params` without having to explicitly list every field (see https://github.com/hackbg/fadroma/blob/e7d5d551f818a6441ef54309a2517792b03ee7d3/packages/namada/src/decode.rs#L201-L223)
this would enable @fadroma/namada to automatically serialize the response from `/vp/governance/parameters` to JSON without having to explicitly list each field (see https://github.com/hackbg/fadroma/blob/e7d5d551f818a6441ef54309a2517792b03ee7d3/packages/namada/src/decode.rs#L201-L223)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
=======================================
Coverage 68.01% 68.02%
=======================================
Files 330 330
Lines 116209 116209
=======================================
+ Hits 79041 79051 +10
+ Misses 37168 37158 -10 ☔ View full report in Codecov by Sentry. |
Collaborator
|
can you run |
Collaborator
|
ah nice catch about the changelog docs, but it would be better to split them into another PR. Could you drop |
Contributor
Author
|
@Fraccaman fixed? |
Fraccaman
approved these changes
Aug 29, 2024
brentstone
added
the
merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 🙇 This PR enables deriving the
Serializetrait for three of the structs that we expose through our bleeding-edge client library, @fadroma/namada.Right now we decode these by manually building
js_sys::Objectinstances, but this requires us to explicitly name each field, hence it is not future-proof against the struct fields changing. As we migrate towards automatic JSON serialization usingserde_json, we've found that not all SDK structs deriveserde::Serialize. Hence, this 🙏