Skip to content

fix client checks on update account #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jul 31, 2024
Merged

fix client checks on update account #3566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c784af9
fix client checks on update account
Fraccaman Jul 30, 2024
deb73e3
added changelog
Fraccaman Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/3566-fix-update-account-client-checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Improve client side checks for update-account transaction.
([\#3566](https://github.com/anoma/namada/pull/3566))
12 changes: 4 additions & 8 deletions crates/sdk/src/tx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3548,11 +3548,10 @@ pub async fn build_update_account(
let threshold = *threshold;

let invalid_threshold = threshold.is_zero();
let invalid_too_few_pks: bool = (public_keys.is_empty()
&& public_keys.len() < threshold as usize)
|| (account.get_all_public_keys().len() < threshold as usize);
let invalid_threshold_updated = !public_keys.is_empty() && public_keys.len() < threshold as usize;
let invalid_threshold_current = public_keys.is_empty() && account.get_all_public_keys().len() < threshold as usize;

if invalid_threshold || invalid_too_few_pks {
if invalid_threshold || invalid_threshold_updated || invalid_threshold_current {
edisplay_line!(
context.io(),
"Invalid account threshold: either the provided threshold is \
Expand All @@ -3567,10 +3566,7 @@ pub async fn build_update_account(

Some(threshold)
} else {
let invalid_too_few_pks = (!public_keys.is_empty()
&& public_keys.len() < account.threshold as usize)
|| (account.get_all_public_keys().len()
< account.threshold as usize);
let invalid_too_few_pks = !public_keys.is_empty() && public_keys.len() < account.threshold as usize;

if invalid_too_few_pks {
return Err(Error::from(TxSubmitError::InvalidAccountThreshold));
Expand Down