Skip to content

Update gas costs #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 12 commits into from
Aug 9, 2024
Merged

Update gas costs #3554

mergify merged 12 commits into from
Aug 9, 2024

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Jul 25, 2024 •
edited
Loading

Describe your changes

Indicate on which release or other PRs this topic is based on

v0.41.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

This was referenced Jul 25, 2024
Closed
Closed
@grarco grarco added gas breaking:consensus Consensus breaking change that requires a hard-fork labels Jul 25, 2024
@codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.94118% with 64 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (26e628a) to head (a1be239).
Report is 856 commits behind head on main.

Files with missing lines Patch % Lines
crates/vm/src/wasm/run.rs 52.94% 64 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
- Coverage   54.54%   54.54%   -0.01%     
==========================================
  Files         323      323              
  Lines      113862   113862              
==========================================
- Hits        62108    62106       -2     
- Misses      51754    51756       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco added a commit that referenced this pull request Jul 25, 2024
@grarco
Changelog #3554
3528658
@grarco grarco force-pushed the grarco/rc-gas-update branch from d25f23d to 3528658 Compare July 25, 2024 15:59
@grarco grarco marked this pull request as ready for review July 25, 2024 15:59
@grarco grarco requested review from Fraccaman and brentstone July 25, 2024 15:59
@grarco grarco marked this pull request as draft July 26, 2024 13:34
@grarco
Copy link
Collaborator Author

grarco commented Jul 26, 2024

Do not merge this yet as we need to review some things with regards to native vps

@brentstone
Copy link
Collaborator

brentstone commented Aug 2, 2024

Any chance we could also add a test? Perhaps one that checks that transparent transfers cost less gas than shielded transfers or similar?

brentstone
brentstone previously requested changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a test.

@grarco grarco mentioned this pull request Aug 6, 2024
Closed
grarco added a commit that referenced this pull request Aug 8, 2024
@grarco
Changelog #3554
1b7329c
@grarco grarco force-pushed the grarco/rc-gas-update branch from 74739c5 to 1b7329c Compare August 8, 2024 13:33
@Fraccaman Fraccaman self-requested a review August 8, 2024 15:23
@grarco grarco force-pushed the grarco/rc-gas-update branch from 1b7329c to f487a37 Compare August 8, 2024 16:47
@grarco grarco marked this pull request as ready for review August 8, 2024 17:13
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 9, 2024
@Fraccaman Fraccaman requested review from brentstone and removed request for brentstone August 9, 2024 11:48
@grarco grarco requested a review from brentstone August 9, 2024 11:50
@Fraccaman
Copy link
Collaborator

Fraccaman commented Aug 9, 2024

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Fraccaman
Copy link
Collaborator

Fraccaman commented Aug 9, 2024

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

refresh

✅ Pull request refreshed

@Fraccaman
Copy link
Collaborator

Fraccaman commented Aug 9, 2024

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d264b78

@grarco grarco removed the request for review from brentstone August 9, 2024 11:52
@Fraccaman
Copy link
Collaborator

Fraccaman commented Aug 9, 2024

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Aug 9, 2024
@mergify
Merge of #3554
3b0a6ae
@mergify mergify bot mentioned this pull request Aug 9, 2024
Closed
@mergify mergify bot merged commit d264b78 into main Aug 9, 2024
@mergify mergify bot deleted the grarco/rc-gas-update branch August 9, 2024 12:35
@grarco grarco mentioned this pull request Sep 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

@Fraccaman Fraccaman Fraccaman approved these changes

@brentstone brentstone brentstone left review comments

Assignees

No one assigned

Labels

breaking:consensus Consensus breaking change that requires a hard-fork gas merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gas metering inconsistency

5 participants

@grarco @brentstone @Fraccaman @tzemanovic