Skip to content

Adjust IBC e2e test config #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brentstone merged 4 commits into from
Jul 5, 2024
Merged

Adjust IBC e2e test config #3455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2e101a
change IBC e2e test config
yito88 Jun 28, 2024
52adb35
clear on start
yito88 Jun 28, 2024
2f9f3c8
add changelog
yito88 Jun 28, 2024
900e162
longer interval
yito88 Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/scripts/e2e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"e2e::eth_bridge_tests::everything": 4,
"e2e::ibc_tests::run_ledger_ibc": 155,
"e2e::ibc_tests::run_ledger_ibc_with_hermes": 130,
"e2e::ibc_tests::pgf_over_ibc_with_hermes": 240,
"e2e::ibc_tests::proposal_ibc_token_inflation": 600,
"e2e::ibc_tests::ibc_rate_limit": 500,
"e2e::ibc_tests::ibc_namada_gaia": 450,
"e2e::ibc_tests::run_ledger_ibc": 110,
"e2e::ibc_tests::run_ledger_ibc_with_hermes": 230,
"e2e::ibc_tests::pgf_over_ibc_with_hermes": 810,
"e2e::ibc_tests::proposal_ibc_token_inflation": 1100,
"e2e::ibc_tests::ibc_rate_limit": 430,
"e2e::ibc_tests::ibc_namada_gaia": 180,
Copy link
Collaborator Author

@yito88 yito88 Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests were changed. Set the latest actual time in CI.

"e2e::eth_bridge_tests::test_add_to_bridge_pool": 10,
"e2e::ledger_tests::double_signing_gets_slashed": 12,
"e2e::ledger_tests::ledger_many_txs_in_a_block": 55,
Expand Down
6 changes: 4 additions & 2 deletions crates/tests/src/e2e/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ pub fn make_hermes_config(test_a: &Test, test_b: &Test) -> Result<()> {

let mut packets = toml::map::Map::new();
packets.insert("enabled".to_owned(), Value::Boolean(true));
packets.insert("clear_interval".to_owned(), Value::Integer(10));
packets.insert("clear_interval".to_owned(), Value::Integer(20));
Copy link
Collaborator Author

@yito88 yito88 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid terminating the packet-clearing thread in Hermes

packets.insert("clear_on_start".to_owned(), Value::Boolean(false));
packets.insert("tx_confirmation".to_owned(), Value::Boolean(true));
mode.insert("packets".to_owned(), Value::Table(packets));
Expand Down Expand Up @@ -614,12 +614,14 @@ fn make_hermes_chain_config(test: &Test) -> Value {
);
chain.insert("store_prefix".to_owned(), Value::String("ibc".to_owned()));
let mut table = toml::map::Map::new();
table.insert("price".to_owned(), Value::Float(0.001));
table.insert("price".to_owned(), Value::Float(0.000001));
Copy link
Collaborator Author

@yito88 yito88 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the practical gas price for the gas estimation feature in Hermes

std::env::set_var(ENV_VAR_CHAIN_ID, test.net.chain_id.to_string());
let nam_addr = find_address(test, setup::constants::NAM).unwrap();
table.insert("denom".to_owned(), Value::String(nam_addr.to_string()));
chain.insert("gas_price".to_owned(), Value::Table(table));

chain.insert("max_block_time".to_owned(), Value::String("60s".to_owned()));
Copy link
Collaborator Author

@yito88 yito88 Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To retry in the longer time


Value::Table(chain)
}

Expand Down
2 changes: 1 addition & 1 deletion crates/tests/src/e2e/ibc_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ fn create_channel_with_hermes(
"--yes",
];

let mut hermes = run_hermes_cmd(test_a, args, Some(120))?;
let mut hermes = run_hermes_cmd(test_a, args, Some(240))?;
Copy link
Collaborator Author

@yito88 yito88 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid timeout for the channel creation handshake

let (channel_id_a, channel_id_b) =
get_channel_ids_from_hermes_output(&mut hermes)?;
hermes.assert_success();
Expand Down