Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented May 16, 2024

Describe your changes

closes #3227

also fixes some rust 2018 idioms and missing docs

Indicate on which release or other PRs this topic is based on

#3214

diff: https://github.com/anoma/namada/pull/3257/files/860132bdfce5e91864bc07808610a39289bd2797..a1c534c52efcf0d8a2797a6f3b976ef6e831b7d2

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic marked this pull request as ready for review May 16, 2024 11:50
@tzemanovic tzemanovic requested a review from brentstone May 16, 2024 12:00
@codecov
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 73.34184% with 209 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (4ed6229) to head (a1c534c).

Files Patch % Lines
crates/namada/src/vm/host_env.rs 82.01% 25 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 60.52% 15 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 13 Missing ⚠️
crates/namada/src/ledger/vp_host_fns.rs 63.33% 11 Missing ⚠️
crates/tx/src/types.rs 68.57% 11 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 70.96% 9 Missing ⚠️
crates/governance/src/cli/validation.rs 0.00% 9 Missing ⚠️
crates/apps/src/lib/config/genesis/chain.rs 33.33% 8 Missing ⚠️
crates/apps/src/lib/node/ledger/mod.rs 0.00% 8 Missing ⚠️
crates/namada/src/ledger/mod.rs 38.46% 8 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
+ Coverage   60.24%   60.26%   +0.02%     
==========================================
  Files         303      303              
  Lines       93191    93453     +262     
==========================================
+ Hits        56145    56323     +178     
- Misses      37046    37130      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brentstone added a commit that referenced this pull request May 16, 2024
* tomas/lint-dbg-and-prints:
  changelog: add #3257
  fix lint warnings
  add lints for dbg and prints (except for in tests)
brentstone added a commit that referenced this pull request May 21, 2024
* origin/tomas/lint-dbg-and-prints:
  changelog: add #3257
  fix lint warnings
  add lints for dbg and prints (except for in tests)
@tzemanovic tzemanovic merged commit 8cb095c into main May 21, 2024
@tzemanovic tzemanovic deleted the tomas/lint-dbg-and-prints branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a lint to warn about dbg_macro

3 participants