Skip to content

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented May 13, 2024

Describe your changes

Closes #3188

Indicate on which release or other PRs this topic is based on

v0.35.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added bug Something isn't working ledger labels May 13, 2024
sug0 added a commit that referenced this pull request May 13, 2024
@sug0 sug0 requested review from cwgoes and grarco May 13, 2024 09:47
@sug0 sug0 marked this pull request as ready for review May 13, 2024 09:47
@codecov
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 89.02439% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (4ed6229) to head (c2b111a).

Files Patch % Lines
...apps/src/lib/node/ledger/shell/prepare_proposal.rs 89.02% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
+ Coverage   60.24%   60.26%   +0.01%     
==========================================
  Files         303      303              
  Lines       93191    93253      +62     
==========================================
+ Hits        56145    56197      +52     
- Misses      37046    37056      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 marked this pull request as draft May 13, 2024 10:18
@sug0 sug0 force-pushed the tiago/fix-validator-gas-prices branch from 4f1fdea to c2b111a Compare May 13, 2024 10:21
@sug0 sug0 marked this pull request as ready for review May 13, 2024 10:21
brentstone added a commit that referenced this pull request May 13, 2024
* tiago/fix-validator-gas-prices:
  Changelog for #3228
  Test `compute_min_gas_price`
  Address block rejections resulting from lower validator gas prices
@tzemanovic tzemanovic merged commit 3c1b639 into main May 21, 2024
@tzemanovic tzemanovic deleted the tiago/fix-validator-gas-prices branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ledger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block could be rejected due to proposer and validators using different minimum gas price

5 participants