Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Apr 24, 2024

Describe your changes

Closes #2794.

Adds the masp commitment tree anchor keys to the merkle tree so that they can be tracked in the app hash.

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco added the breaking:consensus Consensus breaking change that requires a hard-fork label Apr 24, 2024
@grarco grarco marked this pull request as ready for review April 24, 2024 16:44
@grarco grarco requested a review from brentstone April 24, 2024 16:44
@codecov
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (97ec5b4) to head (20949ce).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3125   +/-   ##
=======================================
  Coverage   59.39%   59.40%           
=======================================
  Files         298      298           
  Lines       92771    92780    +9     
=======================================
+ Hits        55104    55116   +12     
+ Misses      37667    37664    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone mentioned this pull request Apr 24, 2024
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brentstone added a commit that referenced this pull request Apr 24, 2024
* grarco/merkle-masp-hashes:
  Fixes merkle unit tests
  Changelog #2794
  Tests masp keys merklization
  Merklize the masp commitment tree anchor keys
@brentstone brentstone merged commit f10ac05 into main Apr 27, 2024
@brentstone brentstone deleted the grarco/merkle-masp-hashes branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:consensus Consensus breaking change that requires a hard-fork

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Track MASP anchor hashes in app hash

3 participants