Skip to content

Conversation

@grarco
Copy link
Collaborator

@grarco grarco commented Apr 24, 2024

Describe your changes

Requested in #1566.

Adds a default expiration to transaction when the user does not provide one.
Adds a new --no-expiration cli flag to allow the user forcing a transaction without expiration.

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 59.39%. Comparing base (97ec5b4) to head (2d436e5).
Report is 10 commits behind head on main.

Files Patch % Lines
crates/sdk/src/args.rs 0.00% 8 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 4 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 4 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 2 Missing ⚠️
crates/apps/src/lib/config/genesis/transactions.rs 0.00% 1 Missing ⚠️
crates/sdk/src/eth_bridge/bridge_pool.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   59.39%   59.39%   -0.01%     
==========================================
  Files         298      298              
  Lines       92771    92777       +6     
==========================================
+ Hits        55104    55106       +2     
- Misses      37667    37671       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco requested a review from tzemanovic April 24, 2024 14:39
@grarco grarco marked this pull request as ready for review April 24, 2024 14:39
@brentstone brentstone mentioned this pull request Apr 25, 2024
brentstone added a commit that referenced this pull request Apr 25, 2024
* grarco/default-tx-expiration:
  Fixes typo
  Changelog #3123
  Custom method instead of `From` implementation for `TxExpiration`
  Adds default tx expiration
@brentstone brentstone merged commit cba9d53 into main Apr 27, 2024
@brentstone brentstone deleted the grarco/default-tx-expiration branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants