Adjusted test vector printing to simplify hardware wallet implementations #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
changed the title
Fraccaman
previously approved these changes
Apr 24, 2024
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
==========================================
+ Coverage 59.39% 59.41% +0.01%
==========================================
Files 298 298
Lines 92771 92754 -17
==========================================
+ Hits 55104 55107 +3
+ Misses 37667 37647 -20 ☔ View full report in Codecov by Sentry. |
brentstone
added a commit
that referenced
this pull request
Apr 25, 2024
* murisi/test-vectors-0.33.0: Added changelog entry. Corrected the printing of test vectors to match serialization order.
brentstone
added a commit
that referenced
this pull request
Apr 25, 2024
* murisi/test-vectors-0.33.0: Added changelog entry. Corrected the printing of test vectors to match serialization order.
murisi
force-pushed
the
murisi/test-vectors-0.33.0
branch
from
2559d34 to
c25dad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Made the adjustments to facilitate the hardware wallet's printing of transactions. More specifically, the ordering used to print the
commissionfield of an update steward commission transaction has been changed to reflect its serialization order. Also removed some dead code pertaining to printing out proposal types.Indicate on which release or other PRs this topic is based on
Namada v0.33.0
Checklist before merging to
draft