Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Mar 20, 2024

Describe your changes

first step toward #2629 - the next step is to update VPs to enforce that insert_verifier has been called with an address that has to authorize the tx (#2934).

Indicate on which release or other PRs this topic is based on

0.32.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 27.90698% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 53.43%. Comparing base (5e0b162) to head (38c9cc2).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/tx_prelude/src/proof_of_stake.rs 0.00% 27 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 2 Missing ⚠️
crates/tx_prelude/src/token.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
- Coverage   53.44%   53.43%   -0.02%     
==========================================
  Files         310      310              
  Lines      101574   101611      +37     
==========================================
+ Hits        54288    54294       +6     
- Misses      47286    47317      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review March 20, 2024 17:23
@tzemanovic tzemanovic requested a review from batconjurer March 22, 2024 12:12
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* origin/tomas/fst-addr-vps:
  changelog: add #2928
  benches: fix VPs exec to include verifiers from tx
  wasm/tx: insert_verifier from txs where needed
  state/write_log: only trigger VPs from a fst addr of a key segment
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/tomas/fst-addr-vps:
  changelog: add #2928
  benches: fix VPs exec to include verifiers from tx
  wasm/tx: insert_verifier from txs where needed
  state/write_log: only trigger VPs from a fst addr of a key segment

# Conflicts:
#	crates/benches/native_vps.rs
#	crates/benches/vps.rs
#	crates/tx_prelude/src/token.rs
@tzemanovic tzemanovic merged commit 05484ce into main Apr 12, 2024
@tzemanovic tzemanovic deleted the tomas/fst-addr-vps branch April 12, 2024 10:22
@grarco grarco mentioned this pull request Sep 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants