Skip to content

Conversation

@batconjurer
Copy link
Collaborator

@batconjurer batconjurer commented Mar 9, 2024

Describe your changes

After auditing the abci++ shims, found some small cleanups.

Indicate on which release or other PRs this topic is based on

v0.33.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer requested a review from tzemanovic March 9, 2024 09:11
@tzemanovic tzemanovic force-pushed the bat/abci-shim-audit branch from 404a1eb to 0a07fe8 Compare March 18, 2024 09:58
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (97ec5b4) to head (5200f0f).
Report is 4 commits behind head on main.

Files Patch % Lines
...ates/apps/src/lib/node/ledger/shims/abcipp_shim.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage   59.39%   59.40%           
=======================================
  Files         298      298           
  Lines       92771    92761   -10     
=======================================
+ Hits        55104    55107    +3     
+ Misses      37667    37654   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman mentioned this pull request Apr 15, 2024
@brentstone brentstone force-pushed the bat/abci-shim-audit branch from 0a07fe8 to 5200f0f Compare April 15, 2024 19:25
brentstone added a commit that referenced this pull request Apr 15, 2024
* bat/abci-shim-audit:
  Added changelog
  [chore]: Cleanup from auditing abci shims
@brentstone brentstone merged commit 6e3b24e into main Apr 27, 2024
@brentstone brentstone deleted the bat/abci-shim-audit branch April 27, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants