Skip to content

Conversation

@batconjurer
Copy link
Collaborator

Describe your changes

Exposes some cometbft genesis params in Namada genesis files. Resolves issue #2026.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer requested a review from sug0 March 4, 2024 09:59
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 8.92857% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 53.92%. Comparing base (2535c9c) to head (b9cc37d).

Files Patch % Lines
crates/apps/src/lib/node/ledger/tendermint_node.rs 0.00% 34 Missing ⚠️
crates/apps/src/lib/config/genesis/templates.rs 17.64% 14 Missing ⚠️
crates/core/src/key/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
- Coverage   53.95%   53.92%   -0.03%     
==========================================
  Files         308      308              
  Lines      100018   100072      +54     
==========================================
+ Hits        53967    53968       +1     
- Misses      46051    46104      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0
Copy link
Collaborator

sug0 commented Mar 4, 2024

the only thing we cared about from this pr was the ability to configure cometbft block sizes, which was implemented here: #2187

@sug0 sug0 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants