Remove IBC token denomination and refactoring #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
changed the title
sug0
previously approved these changes
Oct 27, 2023
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
lgtm, managed to shave off quite a bit of lines!
batconjurer
reviewed
Oct 27, 2023
| ) -> Result<()> { | ||
| let key = storage::receipt_key(port_id, channel_id, sequence); | ||
| // the value is the same as ibc-go | ||
| let bytes = [1_u8].to_vec(); |
Collaborator
There was a problem hiding this comment.
that's a shame we have to allocated a vec for a single byte
batconjurer
reviewed
Oct 27, 2023
batconjurer
previously approved these changes
Oct 27, 2023
Collaborator
batconjurer
left a comment
batconjurer
left a comment
There was a problem hiding this comment.
Generally looks good.
This was referenced Oct 30, 2023
Closed
batconjurer
approved these changes
Nov 2, 2023
23 tasks
sug0
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #1947 and closes #1445 by refactoring for IBC,
Indicate on which release or other PRs this topic is based on
v0.25.0Checklist before merging to
draft