add ibc tx host fn to workaround M1/2 WASM compilation issue #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
changed the title
yito88
approved these changes
Sep 19, 2023
Collaborator
yito88
left a comment
yito88
left a comment
There was a problem hiding this comment.
It works on my M1 Mac! Thank you!
Collaborator
|
should we add this to draft? |
Collaborator
I'm in favor of it. This also was crucial for me to be able to run e2e tests again. |
Collaborator
|
is #1872 still relevant after this merges? |
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tomas/ibc-host-fn-workaround: changelog: #1904 add ibc tx host to workaround M1/2 WASM compilation issue
Collaborator
Author
I think so, we can switch it back to wasm at some point |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As a workaround for #1831, the IBC tx execution is added as a native host fn.
Indicate on which release or other PRs this topic is based on:
0.22.0
Checklist before merging to
draft