Remove unstable feature from integration tests #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bat/feature/int-tests-io
…to bat/feature/int-tests-io
…to bat/feature/int-tests-io
tzemanovic
previously approved these changes
Jul 28, 2023
Collaborator
tzemanovic
left a comment
tzemanovic
left a comment
There was a problem hiding this comment.
nice! (I tried this together with #1768)
Collaborator
|
we could remove nightly from tests builds now - even though it's not 100% necessary it would help with reusing build artifacts with stable build |
…to bat/feature/int-tests-io
…s async for integration testing
…s async for integration testing
…to bat/feature/int-tests-io
…s async for integration testing
…to bat/feature/int-tests-io
Closed
batconjurer
added a commit
that referenced
this pull request
Sep 18, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/bat/feature/int-tests-io: [fix]: Fixed removing tokio dep from wasm targeted builds [chore] Merging in v0.22 [feat]: Refactored the masp integration tests to no longer need the nightly feature [chore]: merge in v0.21.1 [chore]: Formatting [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing [fix]: Fixing downstream async io changes from bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [chore]: merge in v0.21.1 [chore]: Formatting [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing [fix]: Fixing downstream async io changes from bat/generic-io [chore]: rebasing on bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [chore]: Formatting [feat]: After rebasing on bat/generic-io, need to make io read methods async for integration testing [fix]: Fixing downstream async io changes from bat/generic-io [chore]: rebasing on bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [fix]: Fixing downstream async io changes from bat/generic-io [chore]: rebasing on bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [fix]: Fixing downstream async io changes from bat/generic-io [chore]: rebasing on bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [chore]: rebasing on bat/generic-io [feat]: Refactored the masp integration tests to no longer need the nightly feature [feat]: Refactored the masp integration tests to no longer need the nightly feature
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This refactors the integrations tests using generic I/O. This allows use to remove the unstable feature gate.
Indicate on which release or other PRs this topic is based on
Depends on #1746