-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement the Ethereum token whitelist logic in Namada #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5bcfeaf to
fdcff0a
Compare
b2e39c6 to
d3bbb45
Compare
batconjurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several NUT test cases missing from the bridge pool vp. We should check the happy flow. We should check that we reject if an asset is incorrectly labelled. The bridge should also accept NUTs and normals for the same asset simultaneously.
ethereum_bridge/src/protocol/transactions/ethereum_events/events.rs
Outdated
Show resolved
Hide resolved
6df9350 to
b4f4b8a
Compare
b4f4b8a to
1a5966b
Compare
|
Took out the patch that removed |
1a5966b to
5cef5df
Compare
|
added a sanity check in 4b43593 if hints::unlikely(cap < supply) {
panic!(
"Namada's state is faulty! The Ethereum ERC20 asset {token} \
has a higher minted supply than the configured token cap: \
cap:{cap:?} < supply:{supply:?}"
);
} |
306d366 to
e1b0e3e
Compare
c933c91 to
713ba76
Compare
5f29c91 to
65078b6
Compare
65078b6 to
353dc57
Compare
Related to #1290 and anoma/ethereum-bridge#60