This fixes the horrible debugging history on amounts #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the masp crate boundary
…into bat/feature/uint256_amount
We merge in v0.17.2 into amounts from v0.15.0, this means that a lot of logic had to be reconstrcuted from tx.rs rpc.tx, and masp.rs had to be manually changed into the proper SDKized form. Further we had to change the MASP crate that we use from using i64s to i128s since it turned out the conversions were not large enough with i64s
mariari
force-pushed
the
mariari/fixed-amounts-history
branch
from
cecd65a to
ec9a785
Compare
Contributor
Author
|
pls update wasm |
mariari
force-pushed
the
mariari/fixed-amounts-history
branch
from
1235fcb to
714d81c
Compare
brentstone
added a commit
that referenced
this pull request
Jul 3, 2023
* origin/mariari/fixed-amounts-history: [chore] Fixed clippy and formatting [fix]: Fixed serialization bug with amounts. Fixed remaining masp e2e tests Masp e2e tests now passing WIP fixed masp incentives WIP masp incentives passes. But I did something reckless to get there. WIP fixed unspent note calcs WIP small bug fixes and a debugger can be attached WIP WIP fixed bug in collecting unspent notes WIP fixing masp incentives WIP WIP fixed bug in collecting unspent notes WIP fixing masp incentives WIP fixing masp amounts unsorted wips on e2e fix ledger e2e tests stupid test fix: add six zeroes force 0 ibc denoms disambiguate token denom and ibc denom we don't take separators anymore whoops refactor `Dec` to allow negative values WIP fix `pos_bonds` Removed denominated from being called from user contracts Add a new destination for ibc rpc endpoint Fix underflow issue in commisions Remove signed conversion errors Temporary remove check for chain id verification Fix u64 going to Dec from overflowing Improve dec display method Gensis Parsing config issue solved Remove all references to Masp::Amount out of RPC Fixing Masp Amounts to convert on the edges Fix Key from always parsing [chore]: Removed rust_decimal and rust_decimal_macro deps from project [fix]: Fixed proptest in PoS, removed rust_decimal from core and pos crates Fix pos unit tests, change `Dec` precision to 12 places WIP fixing pos unit tests WIP more `Dec` integration and testing (compiling!) [chore]: Added more tests and fixes [fix]: Added tests for Dec, fixed division bug, cleaned up from_str method, added tests, removed some more Decimal types WIP continue replacing rust_decimal crate in PoS Starting replacing rust_decimal crate in PoS Update query_sheilded_balance to handle the multiple denominations Update query_sheilded_balance to handle the multiple denominations [fix]: Refactored gen_sheilded_transfer to only denominate amounts at the masp crate boundary [fix]: Incorporating in review suggestions [feat]: Replaced u128 in governance with u256 [fix]: Fixed makefile recipes for abcipp [feat]: Added multitoken support to MASP [fix]: Fixed wasm tests [feat]: Added sub-prefixs to denom storage read/writes [fix]: Cleanup up the wasms [fix]: Fixed the router tests [fix]: Fixed some conversions to amounts in tests. Fixed PoS state machine tests [chore]: Added test coverage for new token types and fixed the bugs they found [chore]: Formatting [feat]: Fixed unit tests [feat]: First compiling refactor. Now for testing Fixed most of the masp compile issues. May not be logically correct yet WIP: shared/pos: update token to TM voting power conv core/token: make conv from Amount to u128 falliable app/shell: use token::Amount::native_whole for min fee conversion core/transaction/wrapper: add a todo for later core/token: add `write_denom` core/token: add `fn zero` Some more fixes for amount types in the client code temp Fixed errors in core Drafting
brentstone
added a commit
that referenced
this pull request
Jul 3, 2023
brentstone
added a commit
that referenced
this pull request
Jul 3, 2023
* origin/mariari/fixed-amounts-history: [chore] Fixed clippy and formatting [fix]: Fixed serialization bug with amounts. Fixed remaining masp e2e tests Masp e2e tests now passing WIP fixed masp incentives WIP masp incentives passes. But I did something reckless to get there. WIP fixed unspent note calcs WIP small bug fixes and a debugger can be attached WIP WIP fixed bug in collecting unspent notes WIP fixing masp incentives WIP WIP fixed bug in collecting unspent notes WIP fixing masp incentives WIP fixing masp amounts unsorted wips on e2e fix ledger e2e tests stupid test fix: add six zeroes force 0 ibc denoms disambiguate token denom and ibc denom we don't take separators anymore whoops refactor `Dec` to allow negative values WIP fix `pos_bonds` Removed denominated from being called from user contracts Add a new destination for ibc rpc endpoint Fix underflow issue in commisions Remove signed conversion errors Temporary remove check for chain id verification Fix u64 going to Dec from overflowing Improve dec display method Gensis Parsing config issue solved Remove all references to Masp::Amount out of RPC Fixing Masp Amounts to convert on the edges Fix Key from always parsing [chore]: Removed rust_decimal and rust_decimal_macro deps from project [fix]: Fixed proptest in PoS, removed rust_decimal from core and pos crates Fix pos unit tests, change `Dec` precision to 12 places WIP fixing pos unit tests WIP more `Dec` integration and testing (compiling!) [chore]: Added more tests and fixes [fix]: Added tests for Dec, fixed division bug, cleaned up from_str method, added tests, removed some more Decimal types WIP continue replacing rust_decimal crate in PoS Starting replacing rust_decimal crate in PoS Update query_sheilded_balance to handle the multiple denominations Update query_sheilded_balance to handle the multiple denominations [fix]: Refactored gen_sheilded_transfer to only denominate amounts at the masp crate boundary [fix]: Incorporating in review suggestions [feat]: Replaced u128 in governance with u256 [fix]: Fixed makefile recipes for abcipp [feat]: Added multitoken support to MASP [fix]: Fixed wasm tests [feat]: Added sub-prefixs to denom storage read/writes [fix]: Cleanup up the wasms [fix]: Fixed the router tests [fix]: Fixed some conversions to amounts in tests. Fixed PoS state machine tests [chore]: Added test coverage for new token types and fixed the bugs they found [chore]: Formatting [feat]: Fixed unit tests [feat]: First compiling refactor. Now for testing Fixed most of the masp compile issues. May not be logically correct yet WIP: shared/pos: update token to TM voting power conv core/token: make conv from Amount to u128 falliable app/shell: use token::Amount::native_whole for min fee conversion core/transaction/wrapper: add a todo for later core/token: add `write_denom` core/token: add `fn zero` Some more fixes for amount types in the client code temp Fixed errors in core Drafting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.