fix storage rollback #1616
Closed
fix storage rollback #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/fix-rollback
branch
from
c44dc36 to
9463d04
Compare
tzemanovic
force-pushed
the
tomas/fix-rollback
branch
from
9463d04 to
557fb3a
Compare
Fraccaman
added a commit
that referenced
this pull request
Jun 27, 2023
* origin/tomas/fix-rollback: ledger/storage/rocksdb: fix rollback to restore deleted keys test/ledger/storage/rocksdb: add a test for block rollback
Closed
brentstone
added a commit
that referenced
this pull request
Jul 3, 2023
* origin/tomas/fix-rollback: ledger/storage/rocksdb: fix rollback to restore deleted keys test/ledger/storage/rocksdb: add a test for block rollback
Collaborator
|
Merged in v0.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1615
The issue fixed in #1615 was affecting rollback because the iterator without prefix didn't find anything. There's another issue in rollback itself - a key-val that's deleted is not being restored as shown in 5ca18bc.