apps: add namadac utils default-base-dir #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a utility command to print the default base directory that would be used by the Namada command line if a base directory were not provided on the command line or in the environment.
gijswijs
reviewed
Jun 2, 2023
| println!( | ||
| "{}", | ||
| get_default_namada_folder().to_str().expect( | ||
| "expected a default namada folder to be possible to determine" |
There was a problem hiding this comment.
<pedantic>Error message is a bit cryptic</pedantic>
Contributor
There was a problem hiding this comment.
Yeah +1 I'd like to see something else
gijswijs
approved these changes
Jun 2, 2023
gijswijs
left a comment
gijswijs
left a comment
There was a problem hiding this comment.
In theory we should have a unit test even for small features like this.
Fraccaman
added a commit
that referenced
this pull request
Jun 9, 2023
* origin/ray/utils-base-dir: changelog: add #1491 apps: add namadac utils default-base-dir
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 14, 2023
* origin/ray/utils-base-dir: changelog: add #1491 apps: add namadac utils default-base-dir
Fraccaman
pushed a commit
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a utility command to print the default base directory that would be
used by the Namada command line if a base directory were not provided
on the command line or in the environment.