Broadcast validator set update protocol txs from namadac
#1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/ethbridge/offline-valset-upd
branch
from
3fee31a to
05ef908
Compare
cwgoes
reviewed
May 10, 2023
Collaborator
cwgoes
left a comment
cwgoes
left a comment
There was a problem hiding this comment.
ACK, needs a test (as you mention)
sug0
commented
May 10, 2023
Collaborator
Author
|
for the record, I accidentally tested this by corrupting storage (not writing a validator set update proof during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1291
NOTE: The PR is closed, but reviews are still welcome!
TODO: write e2e test that deletes a proof from storage, and uses the new
namadacsub-command to generate the missing proof. on-going effort here: https://p.sicp.me/nHvwQ