Skip to content

Comments

Latvia - Fix holiday names and add missing Vasarsvētki#941

Merged
tinohager merged 6 commits intonager:mainfrom
dzervelce:patch-1
Feb 20, 2026
Merged

Latvia - Fix holiday names and add missing Vasarsvētki#941
tinohager merged 6 commits intonager:mainfrom
dzervelce:patch-1

Conversation

@dzervelce
Copy link
Contributor

LocalName corrections (nominative case per Latvian grammar rules):

  • "Jaunais Gads" → "Jaungada diena"
  • "Lieldienas" → "Pirmās Lieldienas" (consistent with "Otrās Lieldienas")
  • "Līgo Diena" → "Līgo diena" (lowercase 'd')
  • "Jāņi" → "Jāņu diena"
  • "proklamēšanas diena" → "Proklamēšanas diena" (uppercase 'P')
  • "Ziemassvētki" → "Pirmie Ziemassvētki" (consistent with "Otrie Ziemassvētki")
  • "Vecgada vakars" → "Vecgada diena"

EnglishName corrections (per official English translation of the law):

  • "Restoration of Independence day" → "Day of the Restoration of Independence of the Republic of Latvia"
  • "Midsummer Eve" → "Līgo Day"
  • "Midsummer Day" → "Jāņi Day"
  • "Proclamation Day of the Republic of Latvia" → "Day of the Proclamation of the Republic of Latvia"

Added missing public holiday:

  • Vasarsvētki (Pentecost)

Updated source URL to the official law:
https://likumi.lv/doc.php?id=72608

LocalName corrections (nominative case per Latvian grammar rules):
- "Jaunais Gads" → "Jaungada diena"
- "Lieldienas" → "Pirmās Lieldienas" (consistent with "Otrās Lieldienas")
- "Līgo Diena" → "Līgo diena" (lowercase 'd')
- "Jāņi" → "Jāņu diena"
- "proklamēšanas diena" → "Proklamēšanas diena" (uppercase 'P')
- "Ziemassvētki" → "Pirmie Ziemassvētki" (consistent with "Otrie Ziemassvētki")
- "Vecgada vakars" → "Vecgada diena"

EnglishName corrections (per official English translation of the law):
- "Restoration of Independence day" → "Day of the Restoration of Independence of the Republic of Latvia"
- "Midsummer Eve" → "Līgo Day"
- "Midsummer Day" → "Jāņi Day"
- "Proclamation Day of the Republic of Latvia" → "Day of the Proclamation of the Republic of Latvia"

Added missing public holiday:
- Vasarsvētki (Pentecost)

Updated source URL to the official law:
https://likumi.lv/doc.php?id=72608
@tinohager tinohager changed the title fix(LV): correct holiday names and add missing Vasarsvētki Latvia - Fix holiday names and add missing Vasarsvētki Feb 18, 2026
{
return
[
"https://en.wikipedia.org/wiki/Public_holidays_in_Latvia"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not remove the source to wikipedia

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added back the Wikipedia source, and also included the official Latvian law as a second source since that's what the name corrections are based on. Is it okay to keep both, or would you prefer Wikipedia only?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are fine 👍🏻

@dzervelce dzervelce requested a review from tinohager February 18, 2026 12:52
EnglishName = "Day of the Proclamation of the Republic of Latvia",
LocalName = "Latvijas Republikas Proklamēšanas diena",
HolidayTypes = HolidayTypes.Public,
ObservedRuleSet = mondayObservedRuleSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an ObservedRuleSet is set, the holiday does not need to be created twice. A second date is automatically provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@dzervelce dzervelce requested a review from tinohager February 20, 2026 19:32
@tinohager tinohager merged commit 6b26835 into nager:main Feb 20, 2026
1 check passed
@dzervelce dzervelce deleted the patch-1 branch February 20, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants