Address Review Comments on Community PR#34
Merged
Satoru-Shinohara merged 1 commit intoss_portchannel_internalfrom Jul 26, 2024
Merged
Address Review Comments on Community PR#34Satoru-Shinohara merged 1 commit intoss_portchannel_internalfrom
Satoru-Shinohara merged 1 commit intoss_portchannel_internalfrom
Conversation
rathnasabapathyv
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test_app log: Replaced REPLACE with CREATE on initial configuration. All cases passed.
testapp_agg_review_comment.log
REST Call used on PUT at interface level to check that REPLACE/UPDATE on non-existent portchannel fails with the correct err message.