feat(editor): In setup panel only mark credentials as completed if they are tested#25658
Merged
RicardoE105 merged 10 commits intomasterfrom Feb 18, 2026
Merged
Conversation
RicardoE105
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
Bundle ReportChanges will increase total bundle size by 128.79kB (0.31%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
Files in
Files in
Files in
Files in
|
MiloradFilipovic
requested changes
Feb 12, 2026
Contributor
MiloradFilipovic
left a comment
MiloradFilipovic
left a comment
There was a problem hiding this comment.
I feel like this adds some unnecessary redundancy to get the job done:
- When a credential is set up in the
CredentialEditmodal, it is being tested twice, both in the modal and in the composable in the background - We seem to be tracking tested credentials state both in the
setupPanel.storeanduseWorkflowSetupPanel
I would suggest a simpler approach:
- Instead of using
setupPanel.storeas a bridge between the modal and the setup panel, use thecredentials.storeto keep track of tested credentials and their test results - This way we remove
credentialsPendingTestcompletely and all of the new code to that store can be deleted - When a credential is tested from UI, we update it's test status in the
credentials.store useWorkflowSetupStatecomposable listens to this store and marks cards as completed/uncompleted as credential status changes - doesn't re-test anything- Keep the initial credentials check in the composable so we check them when the components load
We can also think about adding some loading state for the initial check, I think it's a bit unexpected for card statuses to change by themsleves
This comment has been minimized.
This comment has been minimized.
MiloradFilipovic
approved these changes
Feb 18, 2026
Contributor
MiloradFilipovic
left a comment
MiloradFilipovic
left a comment
There was a problem hiding this comment.
Looks good 👌
Left a minor comment to prevent memory leaks.
| * When a credential is deleted, unset it from ALL nodes that reference it. | ||
| * This is the symmetric counterpart to setCredential's auto-assignment. | ||
| */ | ||
| listenForCredentialChanges({ |
Contributor
There was a problem hiding this comment.
I think we should also unsubscribe from store once the composable is diposed:
import { computed, onScopeDispose, watch, type Ref } from 'vue';
const stopListeningForCredentialChanges = listenForCredentialChanges({ ... });
onScopeDispose(stopListeningForCredentialChanges);
RicardoE105
deleted the
ado-4817-only-mark-step-as-completed-if-credentials-work
branch
Merged
Contributor
|
Got released with |
Contributor
|
Got released with |
MiloradFilipovic
pushed a commit
that referenced
this pull request
Feb 24, 2026
Merged
MiloradFilipovic
pushed a commit
that referenced
this pull request
Feb 24, 2026
MiloradFilipovic
pushed a commit
that referenced
this pull request
Feb 25, 2026
Merged
MiloradFilipovic
pushed a commit
that referenced
this pull request
Feb 27, 2026
Closed
MiloradFilipovic
pushed a commit
that referenced
this pull request
Feb 27, 2026
Merged
Tuukkaa
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the setup panel marked credential cards as complete as soon as a credential was selected, without verifying that the credential actually works. This could mislead users into thinking their workflow is properly configured when credentials are invalid.
Now, credential cards in the setup panel only show the checkmark after a background credential test
succeeds:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-4817/only-mark-step-as-completed-if-credentials-work
Review / Merge checklist
(conventions)