Skip to content

fix(core): Fix webhook binary data max size configuration#10897

Merged
netroy merged 1 commit into
masterfrom
NODE-1746
Sep 20, 2024
Merged

fix(core): Fix webhook binary data max size configuration#10897
netroy merged 1 commit into
masterfrom
NODE-1746

Conversation

@tomi
Copy link
Copy Markdown
Collaborator

@tomi tomi commented Sep 20, 2024

Summary

Webhook binary data max size was made configurable in #10857. Unfortunately that had a mistake in its logic. Formidable takes the max file size in bytes, not in MBs.

Related Linear tickets, Github issues, and Community forum posts

#10892

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Webhook binary data max size was made configurable in #10857. Unfortunately that
had a mistake in its logic. Formidable takes the max file size in bytes, not in MBs.
Copy link
Copy Markdown
Contributor

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@n8n-assistant n8n-assistant Bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

✅ All Cypress E2E specs passed

@cypress
Copy link
Copy Markdown

cypress Bot commented Sep 20, 2024

n8n    Run #6966

Run Properties:  status check passed Passed #6966  •  git commit 6ae57d8ab6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review NODE-1746
Run status status check passed Passed #6966
Run duration 04m 48s
Commit git commit 6ae57d8ab6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

@janober
Copy link
Copy Markdown
Member

janober commented Sep 25, 2024

Got released with n8n@1.61.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants