Small updates for Python 3.9 (and OpenCV 4.5) compatibility#25
Open
cweickhmann wants to merge 4 commits intomzucker:masterfrom
Open
Small updates for Python 3.9 (and OpenCV 4.5) compatibility#25cweickhmann wants to merge 4 commits intomzucker:masterfrom
cweickhmann wants to merge 4 commits intomzucker:masterfrom
Conversation
…tibility). Successfully tested `derive_cubic.py` with Python==3.9.1, matplotlib==3.3.3, sympy==1.7.1 and numpy==1.19.4 .
Changed divisions of floats by integers to floor division (//) statement (Python3 compatibility). Changed return tuple of cv2.findContours to "new" behaviour (using opencv-python==4.5.1). Successfully tested with python 3.9.1, cv2==4.5.1, numpy==1.19.4, scipy==1.5.4, PIL=8.0.1 .
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Matt,
I found your blog post very interesting and this script very useful. Thanks!
Since I left Python 2.x behind years ago, I check if this can be easily made to work with Python 3.x, and yes it can.
So here are my changes that made your scripts work with Python 3.9.1 and current versions of the relevant modules:
I'd be happy to see this PR incorporated into your version.
-- Christian