"'util.isArray' was deprecated since v4. Use 'Array.isArray()' instead" is sometimes skipped

[nfriedly]

I haven't figured out exactly what causes this yet, but the rule 'util.isArray' was deprecated since v4. Use 'Array.isArray()' instead sometimes doesn't get enforced. See, for example, https://travis-ci.org/watson-developer-cloud/node-sdk/builds/203611751 where the exact same code was linted on node.js v4, v6, and v7 - the rule correctly caught usages of util.isArray() and failed the build on v4, but it incorrectly missed those same usages when running on v6 and v7.

I'm not sure that the test is dependent on the Node.js version though - in retrying locally, I managed to get it to both pass and fail my linting on node v4, so I think that the trigger is something else.

[mysticatea]

Thank you for the report.

However, after I investigated this, I have found this is not a problem of eslint-plugin-node.

node/no-deprecated-api rule is warning about Node.js core modules. If you have the third-party module which has the same name as a core module, node/no-deprecated-api rule ignores it because some deprecated core modules recommend a use of the third-party module which has the same name as itself.

Now, your watson-developer-cloud module seems to depend on util module indirectly. And if npm make flatten dependencies, the third-party util module is chosen instead of core util module. The npm command bundled by Node.js 4 is npm v2, so it does not make flatten dependencies.

In brief, watson-developer-cloud module is using core util module only on Node.js 4, so node/no-deprecated-api reports it. Otherwise, watson-developer-cloud module is using third-party util module, so node/no-deprecated-api ignores it.

[mysticatea]

browserify seems to depend on thirdparty util module.
I'm considering if I change the behavior of node/no-deprecated-api about indirect dependencies.

[mysticatea]

Just linking to #66.

[nfriedly]

Aah, I didn't think of that. Thanks for the clear explanation.

[nfriedly]

Awesome, thanks!

…

On Feb 23, 2017 2:04 AM, "Toru Nagashima" ***@***.***> wrote: Closed #65 <#65> via 17c8ae0 <17c8ae0> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHBILLGbrIJzvInoaT9oCYSCECD8nrdks5rfS-FgaJpZM4MGso7> .