feat: add support for v1.35.0+k3s1#2029
Conversation
Summary of ChangesHello @BrammyS, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the range of supported K3s versions within the project's configuration. It specifically updates the validation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to add support for k3s v1.35.0+k3s1 by adding v1.35 to the list of allowed values for the initial_k3s_channel variable. However, this change appears to be based on a misunderstanding of how to specify k3s versions in this module. The initial_k3s_channel variable is for release channels, and v1.35 is not an active channel yet. To use a specific version, the install_k3s_version variable should be used. Therefore, this change is not necessary and could be misleading.
Features: - feat: bump default k3s to v1.33, autoscaler to v1.33.3 (#2030) - feat: add support for k3s v1.35 (#2029) - feat: add configurable replicas and resources for cluster autoscaler (#2025) - feat: add flannel_backend variable for direct backend control (fixes #2027) - feat: bump system-upgrade-controller to v0.18.0 (fixes #1967) Improvements from AI review: - Add integer validation for cluster_autoscaler_replicas - Document leader election for multiple replicas
Adds support for the v1.35.0+k3s1 release