Skip to content

feat: add support for v1.35.0+k3s1#2029

Merged
mysticaltech merged 1 commit into
mysticaltech:masterfrom
BrammyS:features/1.35-support
Feb 1, 2026
Merged

feat: add support for v1.35.0+k3s1#2029
mysticaltech merged 1 commit into
mysticaltech:masterfrom
BrammyS:features/1.35-support

Conversation

@BrammyS
Copy link
Copy Markdown
Contributor

@BrammyS BrammyS commented Feb 1, 2026

Adds support for the v1.35.0+k3s1 release

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @BrammyS, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the range of supported K3s versions within the project's configuration. It specifically updates the validation for the initial_k3s_channel variable, allowing users to specify v1.35 as a valid channel for initial K3s deployments, thereby ensuring compatibility with the latest K3s releases.

Highlights

  • K3s Version Support: Added support for K3s version v1.35.0+k3s1 by updating the allowed initial_k3s_channel values in the configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add support for k3s v1.35.0+k3s1 by adding v1.35 to the list of allowed values for the initial_k3s_channel variable. However, this change appears to be based on a misunderstanding of how to specify k3s versions in this module. The initial_k3s_channel variable is for release channels, and v1.35 is not an active channel yet. To use a specific version, the install_k3s_version variable should be used. Therefore, this change is not necessary and could be misleading.

Comment thread variables.tf
mysticaltech added a commit that referenced this pull request Feb 1, 2026
Features:
- feat: bump default k3s to v1.33, autoscaler to v1.33.3 (#2030)
- feat: add support for k3s v1.35 (#2029)
- feat: add configurable replicas and resources for cluster autoscaler (#2025)
- feat: add flannel_backend variable for direct backend control (fixes #2027)
- feat: bump system-upgrade-controller to v0.18.0 (fixes #1967)

Improvements from AI review:
- Add integer validation for cluster_autoscaler_replicas
- Document leader election for multiple replicas
@mysticaltech mysticaltech merged commit 42b7b77 into mysticaltech:master Feb 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants