Upgrade traefik default configuration to new traefik-helm requirements#2028
Conversation
Summary of ChangesHello @markus-seidl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Traefik default configuration to align with recent changes in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Traefik configuration to align with new requirements from the traefik-helm chart. The changes from globalArguments to additionalArguments and the restructuring of the HTTP redirection are applied consistently across the default configuration in locals.tf, the documentation in docs/llms.md, and the example file kube.tf.example.
I've found one minor issue in locals.tf where the update results in a duplicate additionalArguments key within the default Traefik values. I've left a comment with a suggestion to resolve it. Otherwise, the changes look good.
|
Link to traefik change traefik/traefik-helm-chart#1603 |
|
@mrjoe7 Do you have any insights what happened to globalArguments? As far as I can tell it has been removed. |
|
@markus-seidl Not sure why it was removed, but found that is was removed in this commit traefik/traefik-helm-chart@baa573c |
This commit includes 5 safe patch fixes: - #2016: Exclude CP nodes from ingress LB when scheduling disabled Adds lb_target_groups local that respects allow_loadbalancer_target_on_control_plane - #2014: Disable root SSH on NAT router when sudo is enabled Improves security by blocking direct root login when sudo access is available - #1944: Fix etcd curl port in README (2379 → 2382) K3s wraps etcd on port 2382, not the standard 2379 - #2007: Bump terraform-fmt-check 2.2.2 → 2.2.3 - #2006: Bump terraform-validate 2.2.2 → 2.2.3 Deferred to MINOR release: - #2028 (Traefik): Breaking traefik_values structure change - #2021 (NAT router): Provider version bump to 1.59.0
4 participants
It was pointed out in !1969 that the traefik configuration for redirections and globalArguments has changed. This PR moves to the new structure.