Skip to content

Add clusterCIDR to Hetzner CCM Helm Chart networking configuration#1930

Merged
mysticaltech merged 2 commits into
mysticaltech:masterfrom
sshcherbinin:fix-hcloud-ccm-cluster-cidr
Oct 15, 2025
Merged

Add clusterCIDR to Hetzner CCM Helm Chart networking configuration#1930
mysticaltech merged 2 commits into
mysticaltech:masterfrom
sshcherbinin:fix-hcloud-ccm-cluster-cidr

Conversation

@sshcherbinin
Copy link
Copy Markdown
Contributor

Fix for #1861

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sshcherbinin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configuration of the Hetzner Cloud Controller Manager (CCM) Helm chart by introducing the clusterCIDR setting. This addition ensures that the Kubernetes cluster's IPv4 CIDR range is explicitly passed to the CCM's networking configuration, resolving a previously identified issue and improving network management within Hetzner-based Kubernetes deployments.

Highlights

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the clusterCIDR configuration to the Hetzner Cloud Controller Manager (CCM) Helm chart values. This is a necessary fix to ensure proper network routing for pods when the CCM is installed via Helm, aligning its behavior with the manifest-based installation. The change is correct, but I've suggested a minor improvement for consistency and robustness in the YAML configuration.

Comment thread locals.tf Outdated
Copy link
Copy Markdown
Owner

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sshcherbinin

@mysticaltech mysticaltech merged commit 6c036bd into mysticaltech:master Oct 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants