Skip to content

Added cert_manager_version var in kube.tf.example#1875

Merged
mysticaltech merged 1 commit into
mysticaltech:masterfrom
PCatinean:master
Sep 16, 2025
Merged

Added cert_manager_version var in kube.tf.example#1875
mysticaltech merged 1 commit into
mysticaltech:masterfrom
PCatinean:master

Conversation

@PCatinean
Copy link
Copy Markdown
Contributor

First off, many thanks for this amazing project, it's truly a great tool that caters to the vast majority of people that use / migrate to Hetzner imo.

I added the cert_manager_version since it was missing from the example but I am thinking we should also probably provide a warning that pinning is a good idea since cert-manager introduces breaking changes across their versions. It just happened to me these last few days.

If this is enough though we can just leave it as is.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @PCatinean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the kube.tf.example configuration by introducing a cert_manager_version variable. This addition allows users to specify and pin the version of the cert-manager Helm chart, which is crucial for maintaining stability and avoiding unexpected issues caused by breaking changes in cert-manager updates. The change provides a clear example for users to manage their cert-manager deployments more robustly.

Highlights

  • Added cert_manager_version to example configuration: A commented-out cert_manager_version variable has been added to kube.tf.example, along with a descriptive comment. This allows users to explicitly set a specific version for the cert-manager Helm chart, providing control over deployments and mitigating issues from breaking changes in newer cert-manager releases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for your contribution! This pull request adds the cert_manager_version variable to the example configuration, which is a valuable addition. As you pointed out in the description, cert-manager can have breaking changes, so pinning the version is important. I've added a suggestion to make the comment more explicit about this recommendation to help users avoid potential issues. Overall, a great improvement.

Comment thread kube.tf.example
Comment on lines +1016 to +1017
# If you want to use a specific cert-manager helm chart version, set it below; otherwise, leave them as-is for the latest versions.
# cert_manager_version = ""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for adding this! As you noted in the PR description, warning users about pinning the cert-manager version is a great idea due to potential breaking changes. The current comment is a good start, but we can make it more explicit to better guide users and align with comments for similar variables. Here's a suggestion to make the recommendation stronger and more informative.

  # It is highly recommended to pin the cert-manager helm chart version, as it often introduces breaking changes.
  # See https://github.com/cert-manager/cert-manager/releases for available versions. If empty, the latest is used.
  # cert_manager_version = ""

Copy link
Copy Markdown
Owner

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mysticaltech mysticaltech merged commit 3b1cfd6 into mysticaltech:master Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants