[Bromley] Add dispute missed collection enquiry#5825
Open
MorayMySoc wants to merge 1 commit intomasterfrom
Open
[Bromley] Add dispute missed collection enquiry#5825MorayMySoc wants to merge 1 commit intomasterfrom
MorayMySoc wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
+ Coverage 82.70% 82.73% +0.02%
==========================================
Files 458 459 +1
Lines 35885 35924 +39
Branches 5879 5890 +11
==========================================
+ Hits 29679 29720 +41
+ Misses 4491 4483 -8
- Partials 1715 1721 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dracos
force-pushed
the
5311-bromley-missed-dispute
branch
from
b8c723e to
ad582f7
Compare
Member
|
I've added a bunch of fixup commits, replacing the status flag with something reading the data it has as discussed, and moving to a subclass (still some code in the hook to decide which page to start with etc), and added the code to deal with the special extra data field on this event type - let me know if it all makes sense! |
Add a flow for disputing a missed collection when containers marked as 'not presented'. Give notices if contaminated or too late to dispute. We normally use the Echo resolution code to map to a response template, but this event type is not using those, but instead setting an extra data field to the outcome of the event.
dracos
force-pushed
the
5311-bromley-missed-dispute
branch
from
ad582f7 to
84d25eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flow for disputing a missed collection when containers marked as 'not presented'.
Give notices if contaminated or too late to dispute.
https://github.com/mysociety/societyworks/issues/5311
[skip changelog]