Conversation
myii
force-pushed
the
feat/merge-travis-matrix-and-add-salt-lint-and-rubocop
branch
from
ae1d6f6 to
139da7e
Compare
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
* To be reused for upcoming `rubocop` settings as well
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60 * Initially mentioned on Slack (@dafyddj): - https://freenode.logbot.info/saltstack-formulas/20191004#c2723464 * Basis for the `git ls-files` invocation (@sblaisot): - https://freenode.logbot.info/saltstack-formulas/20191004#c2724272
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60 * Initially mentioned on Slack (@dafyddj): - https://freenode.logbot.info/saltstack-formulas/20191004#c2723464 * Basis for the `git ls-files` invocation (@sblaisot): - https://freenode.logbot.info/saltstack-formulas/20191004#c2724272
myii
added a commit
to myii/template-formula
that referenced
this pull request
Oct 8, 2019
* Automated using myii/ssf-formula#60
myii
force-pushed
the
feat/merge-travis-matrix-and-add-salt-lint-and-rubocop
branch
from
139da7e to
5a76690
Compare
myii
added a commit
to myii/apt-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/apt-cacher-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/iptables-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/telegraf-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/sysctl-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/locale-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/keepalived-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/collectd-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/vim-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/golang-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/vsftpd-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/logrotate-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/fail2ban-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/dhcpd-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/mysql-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/timezone-formula
that referenced
this pull request
Oct 8, 2019
myii
added a commit
to myii/rkhunter-formula
that referenced
this pull request
Oct 8, 2019
This was referenced Oct 9, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
ci: merge travis matrix, add
salt-lint & rubocop to lint job
saltstack-formulas/postgres-formula#291
Merged
Merged
Merged
Merged
Merged
Merged
Merged
* Main goal: one lint job
* Alternative: split `rubocop` into a separate lint job (`allow_failures`)
* Long-term: to be able to fully revert this commit when a single lint
job can be use for all formulas
* `ufw` is still stuck on `trusty` on Travis
- This doesn't work with when `salt` is installed during the
`salt-lint` installation process (issue with `tornado`)
- Installing via. Python 3 works, albeit much slower
* Automated using #60
```bash
Examining ssf/libcimatrix.jinja of type state
[204] Lines should be no longer that 160 chars
ssf/libcimatrix.jinja:4
{%- macro format_ci_matrix(platforms, inspec_suites_kitchen, inspec_suites_matrix, platforms_matrix, platforms_matrix_commented_includes, semrel_formula, width=4, use_new_travis_format=False ) %}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:28
{#- | # | inc | exc | result | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:30
{#- | 1 | y | [] | TRUE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:31
{#- | 2 | y | n | TRUE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:32
{#- | 3 | y | y | TRUE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:33
{#- | 4 | [] | [] | TRUE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:34
{#- | 5 | [] | n | TRUE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:35
{#- | 6 | [] | y | FALSE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:36
{#- | 7 | n | [] | FALSE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:37
{#- | 8 | n | n | FALSE | #}
[203] Most files should not contain tabs
ssf/libcimatrix.jinja:38
{#- | 9 | n | y | FALSE | #}
[206] Jinja variables should have spaces before and after: {{ var_name }}
ssf/libcimatrix.jinja:70
{{ comment }}- {{instance_and_env }}{{ instance }}
...
Examining ssf/map.jinja of type state
[209] Jinja comment should have spaces before and after: {# comment #}
ssf/map.jinja:10
{## Merge the formulas ##}
```
Owner
Author
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
salt-lint&rubocoptolintjob saltstack-formulas/template-formula#175