Skip to content

feat(pre-commit): finalise rstcheck configuration across all formulas#267

Merged
myii merged 2 commits intomasterfrom
feat/enable-rstcheck-across-remaining-formulas
Oct 10, 2020
Merged

feat(pre-commit): finalise rstcheck configuration across all formulas#267
myii merged 2 commits intomasterfrom
feat/enable-rstcheck-across-remaining-formulas

Conversation

@myii
Copy link
Owner

@myii myii commented Oct 10, 2020

Also includes:

  • refactor(contributing): centralise to use one template

myii added a commit to saltstack-formulas/.github that referenced this pull request Oct 10, 2020
@myii
docs(pre-commit): finalise rstcheck configuration
42321ec 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apache-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
1c2125c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apt-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
2d520d2 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/apt-cacher-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
77f4424 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/arvados-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
9539adf 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/bind-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
800a5e1 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/cert-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
125dffb 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/chrony-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
f876619 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/collectd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
938b8ed 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/consul-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
3bd7a05 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/cron-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
a3fa371 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/deepsea-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
6b59de0 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/devstack-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0a2fa0e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/dhcpd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
52c33c9 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/django-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e0e5b69 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/docker-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
87c737c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/eclipse-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
8882a01 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/epel-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
8039f7c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/exim-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ec51349 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/fail2ban-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
24ab8f7 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/firewalld-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
118eacf 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/golang-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
e7fc872 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/grafana-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
01751a1 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/haproxy-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
0792e26 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/hostsfile-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d6a4e2a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/icinga2-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ab3c855 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/influxdb-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
c80c66e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/iptables-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
a296994 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/letsencrypt-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
30492a3 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/libvirt-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
6d9ea29 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/locale-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
32f6593 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/logrotate-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
bd1dc81 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/lvm-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d07edb1 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/lynis-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
a701519 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/maven-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
fc0bbb4 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/mongodb-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
b9e0df0 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/mysql-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
92bf43a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/nfs-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
6bea9ea 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/nginx-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
33ce43d 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/nifi-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
7a0aa8c 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/node-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
f4009a0 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/ntp-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
5f73fc4 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/nut-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
26928aa 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/openldap-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d8c63a6 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/openntpd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
1eed3db 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/openssh-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
75e843a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/openvpn-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
44e040d 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/packages-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d64b8d8 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/php-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
ab6338e 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/postfix-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
75941ed 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/postgres-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
7036f60 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/powerdns-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
5e79467 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/proftpd-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
b297224 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/prometheus-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
d00473a 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/rabbitmq-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
3e1b397 
* Automated using myii/ssf-formula#267
myii added a commit to saltstack-formulas/redis-formula that referenced this pull request Oct 10, 2020
@myii
ci(pre-commit): finalise rstcheck configuration [skip ci]
13311ce 
* Automated using myii/ssf-formula#267
@myii
Copy link
Owner Author

myii commented Oct 10, 2020

🎉 This PR is included in version 1.219.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@myii
Copy link
Owner Author

myii commented Oct 10, 2020

@dafyddj All done, rstcheck enabled across all formulas. One interesting point, however: you'll notice that I also had to make changes to docs/TOFS_pattern.rst, since this was also triggering a violation when run directly:

deepsea-formula$ git ls-files -- '*.rst' | xargs rstcheck
docs/TOFS_pattern.rst:67: (ERROR/3) Error in "code-block" directive:

Yet not being caught when run through pre-commit. Something worth investigating, if either of us gets the chance. Would have to use an earlier commit, though, since the fix has been pushed through to all formulas using this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@myii