[pull] master from gatsbyjs:master #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teNode on existing node (#28682) ## Description We're currently using `gatsby-source-drupal` to pull content from our D8 site. We precompute some fields to attach to these nodes based on their type. An example of this is fetching some information from TripAdvisor in `onCreateNode` and attaching it to the relevant node using `createNodeField`. This works great but when used in conjunction with the `fastBuilds` flag it causes issues as the node getting recreated already has a `fields` property on it. ## Proposed Solution This PR removes the field before calling `createNode` so that any other `gatsby-node` files utilizing the `onCreateNode` hook can recompute and add back the fields. ## Documentation - [ ] We should add a test for this behavior as well to make sure it's not broken in the future ## Related Issues N/A Co-authored-by: gatsbybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )