[pull] master from gatsbyjs:master #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix srcset in picture tag to make sure we control loading * SAVEPOINT * add ref * this is a key but it's not unique, we don't have an id * use cachekey * this makes way more sense * Update packages/gatsby-plugin-image/src/components/gatsby-image.browser.tsx * update test * order matters * mostly there, still need to bail out when image isn't available * fix the warnings * we shouldn't need to do this, but still verifying * remove console log * address comments * Update packages/gatsby-plugin-image/src/components/layout-wrapper.tsx Co-authored-by: Ward Peeters <[email protected]> * Update packages/gatsby-plugin-image/src/components/layout-wrapper.tsx Co-authored-by: Ward Peeters <[email protected]> * Update packages/gatsby-plugin-image/src/components/gatsby-image.browser.tsx Co-authored-by: Ward Peeters <[email protected]> * eslint ignore needs to follow comments Co-authored-by: Ward Peeters <[email protected]>
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )