NEW: support generic edge publish on the Facebook Graph #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweibel
reviewed
May 22, 2018
lib/facebook.ex
Outdated
| @@ -227,6 +227,23 @@ defmodule Facebook do | |||
| |> GraphAPI.post("", [], params: params) | |||
| |> ResponseFormatter.format_response | |||
| end | |||
Owner
There was a problem hiding this comment.
Can you call the new publish from this function now? Or rather, is it even needed now that the generic publish is here?
Contributor
Author
There was a problem hiding this comment.
Ah good point! I think it could be used here too. It can also safely be removed, what do you think? The only difference is in the type of first parameter which can anyway be a symbol indeed.
Contributor
Author
There was a problem hiding this comment.
@mweibel can you help in understanding why the build is failing please?
bugant
force-pushed
the
support-generic-edge-publish
branch
from
e18d41e to
d194848
Compare
Owner
|
@bugant I fixed the style issues in master and merged the branch manually. Version 0.19.0 with your changes is published on hex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.