Custom dimension picture #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@alexcastano thanks for the PR. 👍 I'd prefer if you refactor the |
Owner
|
ping? |
Contributor
Author
|
Hi @mweibel Well, if you allow for more parameters you break the compatibility with older versions, I thought it was not a good idea. How should be the arguments of this function? Maybe type could be a tuple: iex> Facebook.picture("<Some Id>", "small", "<Access Token>")
iex> Facebook.picture("<Some Id>", {600, 600}, "<Access Token>") |
Owner
|
You could add a function with the same name with different amount of arguments though, no? |
Contributor
Author
|
I don't see to "type" function calls to dimension one, because facebook can change its criteria to match type => dimension at any time. I'll change the name to the function ASAP :) |
Additionally this renames set_appsecret to set_app_secret.
* Fix tests * Fix issues reported by credo * Exclude elixir 1.3 x OTP 20.3
Add two new functions to work with generic objects from the Facebook Graph. This is joint work with @bugduino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function gives the possibility to get images bigger than 200x200 which was my original problem.