-
Notifications
You must be signed in to change notification settings - Fork 63
Add video & photo publishing #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm totally up for that!
Yeah I guess we'd need those in a test folder because Travis CI will need them too. Is this just the path to such a file? |
|
Great, since you're open, I'll make a proposal that introduces HTTPoison in another issue/PR. Yup, just a path to the media files to be published. I removed the environment variables and just reference the sample files which are now located in |
|
This looks good, will test it on my own and see why travis failed later on. Sorry for the delay in reviewing |
|
I'm unsure about the
Could it be that the |
|
|
|
Thanks! Version 0.15.0 has been published on hex. Keep up the good work 👍 |
Provides the functionality that was requested in issue #28
Videos are handled on a separate subdomain than the standard graph api.
Passing the proper tuples to hackney was the only difficult part about this, but the HTTPoison codebase & documentation helped a bit here. While I was digging in I noticed there's quite a bit of overlapping functionality between HTTPoison and
Graph. What are your thoughts on replacing the request/method functions with a dependancy or two?Wasn't sure if we wanted to add static assets to the project to get the tests to pass, my solution was just to use environment variables [
FBEX_PHOTO_FILE,FBEX_VIDEO_FILE] for now so be sure you've got those loaded before runningmix test.