Conversation
Owner
Author
|
cc @dankegel |
andreynering
approved these changes
Oct 21, 2022
theclapp
suggested changes
Oct 21, 2022
Contributor
theclapp
left a comment
theclapp
left a comment
There was a problem hiding this comment.
Nice work. Found some more panics with %, though.
Arithm now returns one more type of error for this case. Update the interpreter accordingly, and add tests. The behavior we adopt follows what Bash does when not run interactively, so start documenting that in the package godoc. Also add a TODO as we should have some standard to tell whether errors coming from the expand package or the user's handlers are fatal. That is, whether they should exit the shell, and with what status code. While here, replace black and white with block and allow, which are more self-explanatory. Fixes #892.
Owner
Author
|
Thanks for the great review, @theclapp. I'll probably bother you for more interpreter reviews, if that's okay :) |
Owner
Author
|
Got a weird failure on Mac I haven't seen before. Maybe the machine crashed somehow. |
theclapp
approved these changes
Oct 21, 2022
Owner
Author
|
I'm perplexed at the repeated macos failure. It happens on pull_request but not on push, which should be the same code. And master passed. And the failure is in the shfmt tests, where it depends on neither of the packages modified here. I'll rerun all the jobs and see... |
Owner
Author
|
Green, so I will ignore that. For the record, they were |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #892.