Fix and simplify layout if all staves invisible #30715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
approved these changes
Oct 24, 2025
its-not-nice
approved these changes
Oct 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30578
Second part of the fix (this should NOT be ported to 4.6.4). Please merge #30713 first.
Part of the issue results from the fact that, when all staves are hidden, some (but not all) layout steps are skipped, and as a result the horizontal spacing logic computes garbage (in fact we also get an assertion failure when trying to justify the empty system). It's worth introducing some more checks to make sure that in this edge case we skip all the unnecessary calculations and, in the case of horizontal spacing, just return zero.